-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types to topic_or_service_is_hidden.py #1231
Add types to topic_or_service_is_hidden.py #1231
Conversation
Signed-off-by: Michael Carlstrom <[email protected]>
@@ -15,7 +15,7 @@ | |||
HIDDEN_TOPIC_PREFIX = '_' | |||
|
|||
|
|||
def topic_or_service_is_hidden(name): | |||
def topic_or_service_is_hidden(name: str) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove the typing info from the param documentation below?
-:param name str: topic or service name to test
+:param name: topic or service name to test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #1230 (comment)
https://ci.ros2.org/job/ci_windows/21184/ is unrelated |
Agreed. Going ahead and merging this one. |
Signed-off-by: Michael Carlstrom <[email protected]>
* First draft of generics Signed-off-by: Michael Carlstrom <[email protected]> * Fix Generic Signed-off-by: Michael Carlstrom <[email protected]> * Add legacy Signed-off-by: Michael Carlstrom <[email protected]> * Fix import order Signed-off-by: Michael Carlstrom <[email protected]> * fix import order Signed-off-by: Michael Carlstrom <[email protected]> * Add Docstrings Signed-off-by: Michael Carlstrom <[email protected]> * Add Docstrings Signed-off-by: Michael Carlstrom <[email protected]> * Add generics support to Node Signed-off-by: Michael Carlstrom <[email protected]> * Update type_support.py Signed-off-by: Michael Carlstrom <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]> * Add types to expand_topic_name (#1238) Signed-off-by: Michael Carlstrom <[email protected]> * Creates Enum wrapper for ClockType and ClockChange (#1235) * Testing out Enum wrapper for ClockType * convert to rcl_clock_type_t * Update create_time_point Signed-off-by: Michael Carlstrom <[email protected]> * Add types (#1231) Signed-off-by: Michael Carlstrom <[email protected]> * Add types to exceptions.py (#1241) * Add types to exception * Add type checking guard * Fix NotInitializedException * Add missing defualt Signed-off-by: Michael Carlstrom <[email protected]> * added python3-yaml (#1242) Signed-off-by: SnIcK <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]> * Add types to duration.py (#1233) * Add types to logging_service.py (#1227) * add types to logging_service * Add types to duration.py * Add newlines for class definintions * update type alias name * Update to use Protocols Signed-off-by: Michael Carlstrom <[email protected]> * Add Static Typing to Validate files (#1230) * Add types to validate files Signed-off-by: Michael Carlstrom <[email protected]> * remove type annotations from docstrings Signed-off-by: Michael Carlstrom <[email protected]> * removed other type annotated docstrings Signed-off-by: Michael Carlstrom <[email protected]> --------- Signed-off-by: Michael Carlstrom <[email protected]> * Add types to TypeHash and moved away from __slots__ usage (#1232) * Add types to TypeHash and moved away from __slots__ usage Signed-off-by: Michael Carlstrom <[email protected]> * remove docstring types Signed-off-by: Michael Carlstrom <[email protected]> --------- Signed-off-by: Michael Carlstrom <[email protected]> * Time.py Types (#1237) * Start typing time.py Signed-off-by: Michael Carlstrom <[email protected]> * Testing out Enum wrapper for ClockType Signed-off-by: Michael Carlstrom <[email protected]> * convert to rcl_clock_type_t Signed-off-by: Michael Carlstrom <[email protected]> * Undo Change to time_point.cpp Signed-off-by: Michael Carlstrom <[email protected]> * Update create_time_point Signed-off-by: Michael Carlstrom <[email protected]> * Lint fixes Signed-off-by: Michael Carlstrom <[email protected]> * Add debug message Signed-off-by: Michael Carlstrom <[email protected]> * Remove test file Signed-off-by: Michael Carlstrom <[email protected]> * Try extending the type assert Signed-off-by: Michael Carlstrom <[email protected]> * Add types to logging_service.py (#1227) * add types to logging_service Signed-off-by: Michael Carlstrom <[email protected]> * Add types to duration.py Signed-off-by: Michael Carlstrom <[email protected]> * Add newlines for class definintions Signed-off-by: Michael Carlstrom <[email protected]> * update type alias name Signed-off-by: Michael Carlstrom <[email protected]> * Remove newline Signed-off-by: Michael Carlstrom <[email protected]> * Merge? Signed-off-by: Michael Carlstrom <[email protected]> * Fix failed merge Signed-off-by: Michael Carlstrom <[email protected]> * Update to use Protocols Signed-off-by: Michael Carlstrom <[email protected]> * Fix import error Signed-off-by: Michael Carlstrom <[email protected]> * Add types to time.py Signed-off-by: Michael Carlstrom <[email protected]> * Linty Signed-off-by: Michael Carlstrom <[email protected]> --------- Signed-off-by: Michael Carlstrom <[email protected]> * Revert "Add types to TypeHash and moved away from __slots__ usage (#1232)" (#1243) This reverts commit b06baef. Signed-off-by: Michael Carlstrom <[email protected]> * Add back Type hash __slots__ and add test cases. (#1245) * Add types to TypeHash and add test cases Signed-off-by: Michael Carlstrom <[email protected]> * Add types to context.py (#1240) Signed-off-by: Michael Carlstrom <[email protected]> * fix pub and sub Signed-off-by: Michael Carlstrom <[email protected]> * Update LifecyclePublisher Signed-off-by: Michael Carlstrom <[email protected]> * Fix docstring Signed-off-by: Michael Carlstrom <[email protected]> * serialization generic Signed-off-by: Michael Carlstrom <[email protected]> * serialization generic Signed-off-by: Michael Carlstrom <[email protected]> * Update type_support.py Signed-off-by: Michael Carlstrom <[email protected]> --------- Signed-off-by: Michael Carlstrom <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]> Signed-off-by: SnIcK <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Co-authored-by: SnIcK <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> Co-authored-by: Shane Loretz <[email protected]>
* First draft of generics Signed-off-by: Michael Carlstrom <[email protected]> * Fix Generic Signed-off-by: Michael Carlstrom <[email protected]> * Add legacy Signed-off-by: Michael Carlstrom <[email protected]> * Fix import order Signed-off-by: Michael Carlstrom <[email protected]> * fix import order Signed-off-by: Michael Carlstrom <[email protected]> * Add Docstrings Signed-off-by: Michael Carlstrom <[email protected]> * Add Docstrings Signed-off-by: Michael Carlstrom <[email protected]> * Add generics support to Node Signed-off-by: Michael Carlstrom <[email protected]> * Update type_support.py Signed-off-by: Michael Carlstrom <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]> * Add types to expand_topic_name (#1238) Signed-off-by: Michael Carlstrom <[email protected]> * Creates Enum wrapper for ClockType and ClockChange (#1235) * Testing out Enum wrapper for ClockType * convert to rcl_clock_type_t * Update create_time_point Signed-off-by: Michael Carlstrom <[email protected]> * Add types (#1231) Signed-off-by: Michael Carlstrom <[email protected]> * Add types to exceptions.py (#1241) * Add types to exception * Add type checking guard * Fix NotInitializedException * Add missing defualt Signed-off-by: Michael Carlstrom <[email protected]> * added python3-yaml (#1242) Signed-off-by: SnIcK <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]> * Add types to duration.py (#1233) * Add types to logging_service.py (#1227) * add types to logging_service * Add types to duration.py * Add newlines for class definintions * update type alias name * Update to use Protocols Signed-off-by: Michael Carlstrom <[email protected]> * Add Static Typing to Validate files (#1230) * Add types to validate files Signed-off-by: Michael Carlstrom <[email protected]> * remove type annotations from docstrings Signed-off-by: Michael Carlstrom <[email protected]> * removed other type annotated docstrings Signed-off-by: Michael Carlstrom <[email protected]> --------- Signed-off-by: Michael Carlstrom <[email protected]> * Add types to TypeHash and moved away from __slots__ usage (#1232) * Add types to TypeHash and moved away from __slots__ usage Signed-off-by: Michael Carlstrom <[email protected]> * remove docstring types Signed-off-by: Michael Carlstrom <[email protected]> --------- Signed-off-by: Michael Carlstrom <[email protected]> * Time.py Types (#1237) * Start typing time.py Signed-off-by: Michael Carlstrom <[email protected]> * Testing out Enum wrapper for ClockType Signed-off-by: Michael Carlstrom <[email protected]> * convert to rcl_clock_type_t Signed-off-by: Michael Carlstrom <[email protected]> * Undo Change to time_point.cpp Signed-off-by: Michael Carlstrom <[email protected]> * Update create_time_point Signed-off-by: Michael Carlstrom <[email protected]> * Lint fixes Signed-off-by: Michael Carlstrom <[email protected]> * Add debug message Signed-off-by: Michael Carlstrom <[email protected]> * Remove test file Signed-off-by: Michael Carlstrom <[email protected]> * Try extending the type assert Signed-off-by: Michael Carlstrom <[email protected]> * Add types to logging_service.py (#1227) * add types to logging_service Signed-off-by: Michael Carlstrom <[email protected]> * Add types to duration.py Signed-off-by: Michael Carlstrom <[email protected]> * Add newlines for class definintions Signed-off-by: Michael Carlstrom <[email protected]> * update type alias name Signed-off-by: Michael Carlstrom <[email protected]> * Remove newline Signed-off-by: Michael Carlstrom <[email protected]> * Merge? Signed-off-by: Michael Carlstrom <[email protected]> * Fix failed merge Signed-off-by: Michael Carlstrom <[email protected]> * Update to use Protocols Signed-off-by: Michael Carlstrom <[email protected]> * Fix import error Signed-off-by: Michael Carlstrom <[email protected]> * Add types to time.py Signed-off-by: Michael Carlstrom <[email protected]> * Linty Signed-off-by: Michael Carlstrom <[email protected]> --------- Signed-off-by: Michael Carlstrom <[email protected]> * Revert "Add types to TypeHash and moved away from __slots__ usage (#1232)" (#1243) This reverts commit b06baef. Signed-off-by: Michael Carlstrom <[email protected]> * Add back Type hash __slots__ and add test cases. (#1245) * Add types to TypeHash and add test cases Signed-off-by: Michael Carlstrom <[email protected]> * Add types to context.py (#1240) Signed-off-by: Michael Carlstrom <[email protected]> * fix pub and sub Signed-off-by: Michael Carlstrom <[email protected]> * Update LifecyclePublisher Signed-off-by: Michael Carlstrom <[email protected]> * Fix docstring Signed-off-by: Michael Carlstrom <[email protected]> * Start implementation Signed-off-by: Michael Carlstrom <[email protected]> * Ungeneric? Signed-off-by: Michael Carlstrom <[email protected]> * Stuff Signed-off-by: Michael Carlstrom <[email protected]> * serialization generic Signed-off-by: Michael Carlstrom <[email protected]> * serialization generic Signed-off-by: Michael Carlstrom <[email protected]> * Update type_support.py Signed-off-by: Michael Carlstrom <[email protected]> * Client Service Generic Implementation Signed-off-by: Michael Carlstrom <[email protected]> * Fix debug relative import Signed-off-by: Michael Carlstrom <[email protected]> * Update imports Signed-off-by: Michael Carlstrom <[email protected]> * Add generics to node.py Signed-off-by: Michael Carlstrom <[email protected]> * Update import order Signed-off-by: Michael Carlstrom <[email protected]> * Remove double bracket Signed-off-by: Michael Carlstrom <[email protected]> --------- Signed-off-by: Michael Carlstrom <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]> Signed-off-by: SnIcK <[email protected]> Co-authored-by: SnIcK <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> Co-authored-by: Shane Loretz <[email protected]>
Added static typing to topic_or_service_is_hidden.py. This change was already done similarly in #979 in response to issue #976.